search

lipis / flag-icons

:flags: A curated collection of all country flags in SVG — plus the CSS for easier integration
https://flagicons.lipis.dev
MIT License
10.67k stars 1.86k forks source link

Unicode flag sequences #729

Closed LukeTOBrien closed 3 years ago

LukeTOBrien commented 4 years ago

Hello there,

I am working on an app which is basicly a Markdown editor and I am using your CSS flags in an Emoji popup that I have.
Users can select select an Emoji to add to their document and one of the Emoji categories is flags, so here I am using you SVG assets as backgound images.
The app is a long way from finished but I wanted to show you how I'm using your flag designs and as I noted some missing flags.

emoji-flags Cool huh?

The missing flags I noted are:

Perhaps this is nickpicking a little bit.

Anyway I appreciate your effort and hard work, my app looks a little bit more professional now!

NotTsunami commented 4 years ago

Hi, I added all 6 flags (most reuse existing flags, as observed by existing emoji sets) in #763

LukeTOBrien commented 4 years ago

Cool! Thanks!

NotTsunami commented 4 years ago

Wouldn't necessarily close this yet as it has yet to be merged. I have "Closes #729" in the git commit so once it is merged, it will automatically close this issue.

LukeTOBrien commented 4 years ago

Hmmm, okay dokey if you insist