lipkau / PsIni

Work with INI files in PowerShell using hashtables
http://lipkau.github.io/PsIni
MIT License
151 stars 50 forks source link

Update Get-IniContent.ps1 #73

Closed tcartwright closed 1 year ago

tcartwright commented 1 year ago

Original code was creating a nested arraylist on the first item when keynames are the same. Which caused the first items to be doubled up into two lists.

Example: Routes=8675309 Routes=1234567 Routes=2345678 Routes=3456789

Was read in, but then would output like below when Out-IniFile was called. The desired output would be to match the existing format. What's worse is that the first value in the list is lost. The line Routes=8675309 disappears when writing the file back out.

Routes= System.Collections.ArrayList 1234567 2345678 3456789 Routes=1234567 Routes=2345678 Routes=3456789

tcartwright commented 1 year ago

Appears the checks are not working properly? Please don't dismiss my PR because of them.

tcartwright commented 1 year ago

Is the repo owner not maintaining this repo any more? I just checked and there are 5 or more (including mine) pull requests for this very same bug. All of which have been ignored. @lipkau can you please pull in one of the PRs? and publish a new module?

lipkau commented 1 year ago

the CI/CD pipeline has been broken for a while. I started migrating it to github actions, but didn't have the time to finish it yet.

I can push the changes manually, but I first I am interested in what versions of powershell are affected by this.

Answer: bug is reproducible on v5.1.22000 and v7.2.6

lipkau commented 1 year ago

version 3.1.3 is released