search

liplum / MultiCrafterLib

A Mindustry mod library provides a multiple-recipe crafter to produce items, fluids, power or even heat for Json and JavaScript mods.
https://liplum.github.io/MultiCrafterLib/
GNU General Public License v3.0
47 stars 10 forks source link

Flashing with two different liquid/gas inputs that have different lightColors #41

Open overdramaticpanromantic opened 5 months ago

overdramaticpanromantic commented 5 months ago

https://github.com/liplum/MultiCrafterLib/assets/108166075/58866d35-713f-4b58-be72-be3e8584d856

https://github.com/liplum/MultiCrafterLib/assets/108166075/7a0be95f-1fad-4819-9972-c563a2c4aa39

Blocks that have two different liquid or gas inputs flash very quickly, which can be dangerous for those with epilepsy. It's also not good-looking.

Presumably, this happens because the amount of liquid bars the block has is always one, and doesn't vary dynamically based on the selected recipe, but I know next-to-nothing about java, so correct me if I'm wrong.

This also causes liquid inputs to fall out of the conduits connected to the block, and thus, using conduits is not possible, as it can burn down blocks. image In this image, if I disconnect power, the conduits stop working and everything burns to the ground.

overdramaticpanromantic commented 5 months ago

Maybe it could iterate through the liquids: {} field and increment the number of bars to put on the right GUI?

JojoFR1 commented 5 months ago

Bars flashing was (almost) fixed Didn't look or yet encountered the flashing lights