search

lipoja / URLExtract

URLExtract is python class for collecting (extracting) URLs from given text based on locating TLD.
MIT License
242 stars 61 forks source link

feat(typing): add typing #114

Closed georgettica closed 1 year ago

georgettica commented 2 years ago

closes https://github.com/lipoja/URLExtract/issues/113 and should address https://github.com/georgettica/url-checker/blob/master/.github/workflows/verify.yml#L67-L69

georgettica commented 2 years ago

awaiting approval @lipoja

I just followed guides and vscode, the local github actions fail on tests, so I don't know if what I did will solve my issue

if you know more than me on the subject feel free to comment/commit on the branch

mimi89999 commented 2 years ago

Hi, Is there any progress on this?

georgettica commented 2 years ago

Not really, lost context almost totally on this

georgettica commented 2 years ago

If you can test this works as expected feel free

mimi89999 commented 2 years ago

Could you please rebase on master?

mimi89999 commented 2 years ago

I opened https://github.com/lipoja/URLExtract/pull/132

georgettica commented 2 years ago

This would be easier:)

lipoja commented 1 year ago

Thank you both for contribution - I am sorry that I was not faster. :( Closing in favor of https://github.com/lipoja/URLExtract/pull/132