search

lipp / login-with

Stateless login-with microservice for OAuth
https://login-with.com
MIT License
2.32k stars 143 forks source link

Add port to rootURL #63

Closed slavaGanzin closed 4 years ago

slavaGanzin commented 5 years ago

I've tried to run login-with on non default port and providers redirected me back without a port (where my non login server spins)

I added port and it just works...

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 99.394% when pulling 0537ae2c23e92266d1301924648279f546f2b017 on slavaGanzin:add-port into 9dbe5fa7c53c18fd40380ecab49fe9f927f8dc54 on lipp:master.

lipp commented 4 years ago

thx. what if opts.port is not defined?

slavaGanzin commented 4 years ago

thx. what if opts.port is not defined?

it has default value:

https://github.com/lipp/login-with/blob/master/src/opts.js#L12

slavaGanzin commented 4 years ago

@lipp Will this be merged?