lipp / lua-websockets

Websockets for Lua.
http://lipp.github.com/lua-websockets/
MIT License
399 stars 114 forks source link

[Bug Fix] I was stuck almost two days by this bug! #41

Closed davidxifeng closed 10 years ago

davidxifeng commented 10 years ago

Sec-Webs [S] ocket-Accept

some client like libwebsockets can't finish handshake with this bug...

https://github.com/warmcat/libwebsockets/issues/155

lipp commented 10 years ago

@DavidFeng THX!

davidxifeng commented 10 years ago

it's nothing important but if you would like to know the Chinese above, here are the translations:

这算是客户端的BUG。 :-)

This is a bug of that websockets client library.

算是吧,新版libwebsockets已经改成大小写不敏感了,标准里并没有关于此做出明确规定 Kind of, current libwebsockets library have changed to case-insensitive. the RFC 6455 did NOT specify case-sensitive or not.

lipp commented 10 years ago

Ah, thx. Actually header filed names are not case sensitive: http://stackoverflow.com/questions/5258977/are-http-headers-case-sensitive

So, this PR is not required by any standard. But if there are client libs which are case sensitive, then lua-websockets should care I guess.