search

lipp / lua-websockets

Websockets for Lua.
http://lipp.github.com/lua-websockets/
MIT License
396 stars 113 forks source link

Separate rockspecs for each backend. #52

Open moteus opened 9 years ago

moteus commented 9 years ago

This allows install only needed modules without additional deps.

lipp commented 9 years ago

this is a very clean approach. i am hesitating though since this will releases and versioning more complicate i guess. maybe we can add some tag/release script to this PR?

moteus commented 9 years ago

maybe we can add some tag/release script to this PR?

You mean generate rockspecs? I work on Windows so I think I can use only Lua (not bash) Maybe somewhere there is such a tool.

moteus commented 9 years ago

I found that websocket.tools uses mime module from luasocket. So I have two options

  1. Add luasocket in dependencies to websocket.core
  2. Use some base64 module. And check at load time which one to use (base64, basexx, luasocket). In this case I suggest add basexx module as dependency because it pure Lua module.
lipp commented 9 years ago

@ntd introduced using luasocket mime here: https://github.com/lipp/lua-websockets/commit/40a02ae4072728e0e4ccd60a0beffacc8b26c6df

lluv changes the premises as every other (minimal) impl always required luasocket.

i'd like to re-add the base64 variant from: https://github.com/lipp/lua-websockets/blob/8c70f5e62e55bdd99dc57ab20f73fdb20cd07c01/src/websocket/tools.lua#L111

so dependencies are not going wild.