let connect return subprotocol and http headers

lipp / lua-websockets

Websockets for Lua.

http://lipp.github.com/lua-websockets/

MIT License

396 stars 113 forks source link

let connect return subprotocol and http headers #73

Closed lipp closed 7 years ago

lipp commented 9 years ago

@KSDaemon tests are failing: https://travis-ci.org/lipp/lua-websockets/jobs/59211205

please look at the bottom of the log.

Could you please fix it?

sorry it took so long. getting busted working again was aweful.

KSDaemon commented 9 years ago

Hi! Ok, i'll take a look.

KSDaemon commented 9 years ago

Hi all! I've fixed some errors in tests. But still there will be some failing tests :( As i can see, that's because autobahn does not return sec-websocket-protocol header. I've run tests against wiola, and that things works. I don't think, that we should remove failing checks, because they are especially for checking new functionality. What do you think?

KSDaemon commented 8 years ago

Hi, @lipp! Any plans to merge or somehow proceed this issue? I have an issue in Loowy, that depends on this :( So for now, installing Loowy through luarocks fails, because lua-websockets version, published to luarocks does not contain needed fixes.

coveralls commented 8 years ago

Coverage decreased (-0.6%) to 90.978% when pulling 5351767ee9df095ded1fb9900d857f6e2093914f on KSDaemon:master into 61cca37c9257ce68df6cc94300d5a191a365687d on lipp:master.

coveralls commented 7 years ago

Coverage increased (+0.09%) to 91.378% when pulling 75b82a4cbccbd2e732c2cbed777c0e53263cfafa on KSDaemon:master into f86b1709ca962b9c95b1bf192c4c4b7398e79832 on lipp:master.