search

lipp / lua-websockets

Websockets for Lua.
http://lipp.github.com/lua-websockets/
MIT License
396 stars 113 forks source link

Extracted mime instantiation to outer scope #86

Closed afan1 closed 8 years ago

afan1 commented 8 years ago

...so that even if base64_encode is called later on without require function available, the code still works.

This is for the case that if we instantiate a websocket client in a pseudo sandboxed environment where the require function has been set to nil (_G.require = nil) we can still use the websocket client without it crashing.

lipp commented 8 years ago

@afan1 did the tests run for you ok locally?

lipp commented 8 years ago

@afan1 just updated the Dockerfile so you should be able to run the tests

docker build .
lipp commented 8 years ago

sorry...didnt see the change was so tiny :)