liprec / powerbi-d3jsvisual

Home of the code of my Power BI Custom Visual: D3JS Visual
MIT License
57 stars 20 forks source link

d3 evaluation fails when data contains the ' character #4

Open gorgi opened 6 years ago

gorgi commented 6 years ago

Here's an example file: https://www.dropbox.com/s/t4ko7hx0dea8921/testdata.pbix?dl=0

If you use the slicer on the left to select rows that contain ' character, the text "Hello!" will not print. If you select a row that doesn't contain the character, the text will be printed.

I tried this in the Power BI service just to see the console output and this is the error I get: "Error during D3js code evauation: undefined"

I suspect that the error is caused by this line: https://github.com/liprec/powerbi-d3jsvisual/blob/master/src/visual.ts#L399

@liprec Is there anyway to escape the ' character from the data?

liprec commented 6 years ago

Thanks for this bug report: the Power BI data needs indeed to be escaped.

avlevashov commented 1 year ago

I solved this issue by passing data (text) encoded with base64 which is available in Power Querry M. and then decode it back to text using function atob() in javascript. this works well and easy but need some additional action to prepare data. it would be good to have checkbox in settings of visual to encode all columns with base64.