Scenario: when aas is taking long to load model, our developer may cancel the job. This leaves a firewall rule named vsts-release-aas. When the job is executed again, a naming conflict prevents the job from proceeding.
A similar issue was reported in #35 but the code addition in commit 1e3f5e5802ed4d5757983094e73eceee2fc9ed27 will not work because variable $addedFirewallRule, never previously referenced, was null and thus interpreted as false. This causes the condition door to remain closed in all circumstances. The variable $addedFirewallRule should be removed.
digihunch
commented
3 years ago
Scenario: when aas is taking long to load model, our developer may cancel the job. This leaves a firewall rule named vsts-release-aas. When the job is executed again, a naming conflict prevents the job from proceeding. A similar issue was reported in #35 but the code addition in commit 1e3f5e5802ed4d5757983094e73eceee2fc9ed27 will not work because variable $addedFirewallRule, never previously referenced, was null and thus interpreted as false. This causes the condition door to remain closed in all circumstances. The variable $addedFirewallRule should be removed.