search

liprec / vsts-release-aas

Repository for my Analysis Service Azure pipelines tasks related to Azure Analysis Service or Power BI Premium
Other
27 stars 28 forks source link

liprec#53 update condition check for firewall rule deletion #53

Closed digihunch closed 3 years ago

digihunch commented 3 years ago

Scenario: when aas is taking long to load model, our developer may cancel the job. This leaves a firewall rule named vsts-release-aas. When the job is executed again, a naming conflict prevents the job from proceeding. A similar issue was reported in #35 but the code addition in commit 1e3f5e5 will not work because variable $addedFirewallRule, never previously referenced, was null and thus interpreted as false. This causes the condition door to remain closed in all circumstances. The variable $addedFirewallRule should be removed.

commit e42d894 proposed to remove undeclared variable addedFirewallRule from condition check

liprec commented 3 years ago

Thanks for your PR and the change is included in the v1.3.5 release that is currently available