liprec / vsts-release-aas

Repository for my Analysis Service Azure pipelines tasks related to Azure Analysis Service or Power BI Premium
Other
27 stars 28 forks source link

Lost inline TMSL content after bugfix #78

Closed trondis80 closed 2 years ago

trondis80 commented 2 years ago

Hi and thanks for creating and managing a great tool!

We are using the Analysis Services deployment task for lots of stuff. We noticed that after your latest release our inline TMSL scripts were gone. I see in your code (execute-aas-tmsl/v1/task.json) that you did a renaming of tsmlScript to tmslScript. I suspect that this is why the content disappeared. We also needed to set a few other parameters.

We were able to go to the task history and recover the code.

Just wanted to let you know in case other people has this problem, or if you are considering future versioning strategies or "backward compatibility".

Cheers, Trond

liprec commented 2 years ago

Sorry to hear that, but the tmslScript option does have the old (incorrect) tsmlScript as alias. To my understanding this should cover the old options. Is it possible to share the task yml and log (with System.Debug set to true) of the failed run, so I can take a look why it is not working as expected?

trondis80 commented 2 years ago

It wasn't a failed run, the (classic) pipeline editor showed those red warnings "some settings need attention" (see image below) and the pipeline could therefore not be run or saved.

image

We needed to reconfigure service connection, database name and the inline TMSL scripts before we were able to run the pipelines.

Like I said, we got it to work after these adjustments.

liprec commented 2 years ago

Thanks for the feedback, but probably I have to fiddle with the variables again as the current configuration gives some strange behavior. But I am thinking about moving the inputs to a different section in the UI, so at least you are not missing the information.

liprec commented 2 years ago

In the latest update I have updated the inputs (again) and now the old inputs are now part of the Deprecated inputs section so you can copy-paste those to the correct values when you are ready. The task only warns when the old values are being used, but still completes are expected.

trondis80 commented 2 years ago

Thanks, I got the update this morning:-) I couple of observations:

image

liprec commented 2 years ago

Indeed probably the updates you did yesterday had already the expected result. And sorry about the service connections: I had to change those also, but unfortunately this kind of changes seems to have a huge impact on the classic UI. Hope that everything is now running as expected.

trondis80 commented 2 years ago

Everything is good, thanks again for a wonderful tool!

liprec commented 2 years ago

Closing the issue and feel free to open a new issue if you have feedback in the future.