search

lipu-tenpo / liputenpo.org

https://liputenpo.org using https://www.11ty.dev/
https://liputenpo.org/
5 stars 4 forks source link

light theme experimentation #113

Open alifeee opened 2 months ago

alifeee commented 2 months ago

an experiment with light theme

this is built upon https://github.com/lipu-tenpo/liputenpo.org/pull/86 so that should be merged first

this is really just an experiment. what do you think ?

see deployment below

adds a CSS background (#89)

parameterised a lot of CSS variables for (easier) switching

github-actions[bot] commented 2 months ago

surge: deployed to https://liputenpotest-113.surge.sh

ngsilverman commented 2 months ago

Overall I like this a lot! Maybe some of the colors could be tweaked a little, for example I think the link color could be darker. I would also be curious to see this without the patterned background, just a very light (near-white) color.

alifeee commented 2 months ago

here is #eeeeee, no background tiling

image

alifeee commented 2 months ago

I agree with the colours, some are still a little off

do you think it's worth trying to have a dark/light switcher, or not ?

ngsilverman commented 2 months ago

Re: background, maybe could go for a lighter gray or even pure white, but I already prefer that to the tiling. Maybe that divider under the logo/menu could be a good place to add some color or a little pattern rather than a simple line. What do you think?

Re: dark/light switcher, I don't mind not having it personally, but I do know that some people really appreciate having a dark mode available so if it's not too much work I think it's worth offering that. ☺️

alifeee commented 1 month ago

Re: background, maybe could go for a lighter gray or even pure white, but I already prefer that to the tiling. Maybe that divider under the logo/menu could be a good place to add some color or a little pattern rather than a simple line. What do you think?

sounds good to me ! perhaps we could ask someone to draw a nice SVG separating line.

Re: dark/light switcher, I don't mind not having it personally, but I do know that some people really appreciate having a dark mode available so if it's not too much work I think it's worth offering that. ☺️

It should be okay. The only thing will be that the auto-generated colours (names/issues) will only really fit either the dark or light theme (or we would have to change how they are done)

I may give this a go if I find some time. Otherwise, this will hang around