lipu-tenpo / liputenpo.org

https://liputenpo.org using https://www.11ty.dev/
https://liputenpo.org/
5 stars 4 forks source link

Add pdfs.hbs [WIP] #118

Closed cstby closed 2 weeks ago

cstby commented 3 weeks ago

This is a first shot at issue #117.

A few notes:

Any and all feedback is welcome!

github-actions[bot] commented 3 weeks ago

surge: deployed to https://liputenpotest-118.surge.sh surge: deployed to https://liputenpotest-118.surge.sh surge: deployed to https://liputenpotest-118.surge.sh surge: deployed to https://liputenpotest-118.surge.sh surge: removed the deployment on https://liputenpotest-118.surge.sh

alifeee commented 3 weeks ago

toki a! pona mute tawa sina tan pali sina a

this looks great :)

as the bot says, we can find a preview on https://liputenpotest-118.surge.sh/ (but because of filesize, the preview does not have PDFs)

when I made the issue, I was just imagining a pretty plaintext-list, but the images and layout makes it look nice :)

a few notes:

overall this is a wonderful change ! thanks for giving it an attempt :)

I hope you find eleventy to your pleasure.

with changes to the note of my notes, this is easily ready to merge and a good page (almost an easter egg of a page ;)

cstby commented 3 weeks ago

Thanks again for the quick feedback!

I noticed that the long copy "lipu walo tawa ilo sitelen" used the full width and spilled over onto a second line. My final commit adds some styling changes to make each lipu wider so that each pdf link only uses one line. I think this looks a little better, but it's totally up to you whether you'd prefer not to add any additional CSS (or to go a different direction with the design of this page).

alifeee commented 3 weeks ago

the CSS is fine with me!

this looks ready to merge !!

only one thing I should have said before: I think we should put a link at the top of the page that says "download all" or similar (in toki pona), which links to https://github.com/lipu-tenpo/liputenpo.org/tree/main/pdfs

after that I will merge it :) thank you for doing this

cstby commented 2 weeks ago

Added in that link in a new line in the introduction section!

alifeee commented 2 weeks ago

I have made a small change to move the URL to sona.yaml (in _data), so as to not have implementation-specific (GitHub) stuff in the HTML templates.

thanks a lot for this !! I will merge and it should be visible on the site soon :)