search

liqd / a4-meinberlin

The central participation platform of the city of Berlin, Germany
https://mein.berlin.de
GNU Affero General Public License v3.0
40 stars 6 forks source link

"Unknow Account"-Email-Template is not showing email adress #5620

Closed pascalkienast closed 1 month ago

pascalkienast commented 5 months ago

URL: https://mein.berlin.de/accounts/password/reset/ (on prod!!) user: any expected behaviour: if you reset your password, but the email adress does not exist, you get an email with it (meinberlin/templates/account/email/unknown_account.de.email) behaviour: see screenshot. the "{{ email }}" from the email template get replaced with an error code like <meinberlin.apps.users.adapters.UserAccountEmail object at 0x7fe185a58cd0> important screensize: any device & browser: any Comment/Question: On A+-Prod this is working! - so, this is not an a4 issue i guess? . Theoretically, this could be solved very quickly by simply removing the variable in the email template and no longer explicitly writing out the email address. But the better solution would be to look why mB can't access the email-variable

Bildschirmfoto 2024-05-30 um 14 59 49
m4ra commented 5 months ago

mB prod has an updated django-allauth, which influenced some of our templates, this is not the case of a+ prod, as we haven't released any updates since last year. We caught during mB testing, the password _reset and verification_sent templates, but sadly not this one. @pascalkienast can you check if that's the case with unkown email also with aplus-dev, as we have merged the django-allauth updates there already.

pascalkienast commented 5 months ago

@m4ra yes, on aplus-dev it is the same issue

Bildschirmfoto 2024-05-30 um 15 41 52
m4ra commented 5 months ago

OK, thank you, should we make a fix and a hotfix release for mB, after the a+ release? @CarolingerSeilchenspringer

m4ra commented 5 months ago

@pascalkienast can you create the same issue in a+ and add it to the milestone Issue Story? thank you!

CarolingerSeilchenspringer commented 5 months ago

@m4ra as there is a work around and edge case I would not do a hotfix release, next regular release is enough.

pascalkienast commented 5 months ago

@m4ra the issue is now also on a+ https://github.com/liqd/adhocracy-plus/issues/2696

m4ra commented 5 months ago

same issue with email "account already exists". @CarolingerSeilchenspringer both will be fixed with what we did for aplus