search

liqd / a4-meinberlin

The central participation platform of the city of Berlin, Germany
https://mein.berlin.de
GNU Affero General Public License v3.0
40 stars 6 forks source link

[#8232] update user facing variables #5679

Closed hom3mad3 closed 1 month ago

hom3mad3 commented 1 month ago

streamline and organize the user-facing variables

hom3mad3 commented 1 month ago

tried to fixed linter but still complaining, wasn't really complaining about spaces before actually.. not sure :/

hom3mad3 commented 1 month ago

looks good to me, I'm a bit uncertain of whether removing all placeholders variables is a good or bad idea to me. On one hand it makes reading easier as you know the value, on the other changing e.g. the text color means changing it in a lot of places. I'm fine going with this as this is your area of expertise though.

Let's use a mix of placeholders and set default values. Style guide values aren't always accurate, so placeholders can help keep things consistent.

hom3mad3 commented 1 month ago

@goapunk just realized, i forgot to unstage the changes made in the components i'm not loading