search

liqd / a4-product

A modern online participation platform for everyone developed by Liquid Democracy
http://beteiligung.in
GNU Affero General Public License v3.0
16 stars 3 forks source link

Follow function #738

Closed philli-m closed 5 years ago

philli-m commented 5 years ago

Auto following after participation does not show on the follow button if user has previously followed and un-followed that project

MagdaN commented 5 years ago

I think this is not a bug. The autofollow will only work once - so that I'll be a follower after I first added a comment or an idea to a project. If I then unfollow I am not made follower again when I add another idea or comment. It would be annoying otherwise, right?

philli-m commented 5 years ago

Good point! the behavior was a little different however; the first follow was not an auto follow, i clicked follow, I then clicked un-follow and I then participated. But still it's a total edge case so maybe it's not a problem?

MagdaN commented 5 years ago

There is a another issue that might cause the problem that you have? https://github.com/liqd/adhocracy4/issues/104

MagdaN commented 5 years ago

and here: https://github.com/liqd/a4-opin/issues/1086

MagdaN commented 5 years ago

maybe we should just fix it ;-)

rittermo commented 5 years ago

Thanks for identifying the issue, @phillimorland. I think it would be important to fix that, so I added it to a – brand new – milestone for this sprint.

fuzzylogic2000 commented 5 years ago

@rittermo @phillimorland It shouldn't matter if the first follow was an autofollow or a voluntary follow. There should be no autofollowing after any unfollow!

MagdaN commented 5 years ago

Could we make a new userstory out of this and fix it for all projects, as this only came up when we were working on the newsletter. I already added a story to the technical backlog.

rittermo commented 5 years ago

Hmmm, I understand that you want to fix it for all platforms, but I would be a bit disappoingted that we have a user story that is only half-finished and feels broken. From a PO perspective investing 5 SP in that is a bit hard to swallow.

MagdaN commented 5 years ago

It has been broken for a very long time ...

rittermo commented 5 years ago

I understand, but I thought that fixing this particular issue here would be in the scope of this story.

rittermo commented 5 years ago

Okay, I tested this again and it works as expected for me. Once I clicked unfollow, I will not be automatically added as a follower again. I think we would need to explain this behavior better, but that is indeed for another user story. Thanks for the clarifications!