search

liqd / a4-product

A modern online participation platform for everyone developed by Liquid Democracy
http://beteiligung.in
GNU Affero General Public License v3.0
16 stars 3 forks source link

#2190 Share buttons don’t work #927

Closed rittermo closed 5 years ago

rittermo commented 5 years ago

There are some issues with the share buttons for use cases.

For twitter, the URL is not added correctly. There is an additional “https” added the URL

Facebook seems to work, but Facebook has a new share dialog which can be invoked via a different share URL pattern (see: https://developers.facebook.com/docs/sharing/reference/share-dialog)

The share button LinkedIn did not share anything in my testing but just made me visit LinkedIn.

philli-m commented 5 years ago

@MagdaN can we have a look at the facebook thing together? I assume we want to use the url redirect to open a new page like we have with our other share btns but the unique app identifier requires additional javascript which i'm not sure about

fuzzylogic2000 commented 5 years ago

@MagdaN Did you fix it? Can we close it?

MagdaN commented 5 years ago

@fuzzylogic2000 @phillimorland I fixed the url to the image so that all meta tags should work now. I did not implement the js facebbok dialog