liqd / adhocracy-plus

adhocracy+ is a SaaS platform to make digital democracy easy for everyone
https://adhocracy.plus/
GNU Affero General Public License v3.0
78 stars 20 forks source link

#7637 [a+] big django & wagtail update: Error-Symbol in "Dokument" Tab doesn't work correctly in "Text Diskutieren" Module #2590

Closed sblindow closed 4 months ago

sblindow commented 5 months ago

URL: You need to add a new "Text Diskutieren" Module in any project to recreate this issue.

user: Initiators

expected behaviour: When I enter Text in the "Dokument" Tab in the "Text Diskutieren" Module, the red exclamation mark should disappear after saving, to indicate that everything has been entered correctly.

behaviour: Currently, the exclamation mark does not disappear after saving. Only when switching to another tab, for ex. "Phasen", does it vanish.

important screensize: not relevant

device & browser: MacOS, Firefox 125.0.2 (64-Bit)

Screenshot?

Bildschirmfoto 2024-04-24 um 13 01 54

"Dokument" Tab in fresh "Text Diskutieren" module

Bildschirmfoto 2024-04-24 um 13 02 42

Text has been entered.

Bildschirmfoto 2024-04-24 um 13 02 50

After saving the changes, the red exclamation mark on the left does not disappear, although the criteria to publish the module are met.

Bildschirmfoto 2024-04-24 um 13 02 59

Only after switching to another tab, does it clear.

hom3mad3 commented 4 months ago

@TeaJayyy @sblindow How important is this? It requires more custom JS development, which we'd prefer to avoid due to potential bloat and complexity. Also, to prioritize the release asap.

TeaJayyy commented 4 months ago

@hom3mad3 it has low priority!

hom3mad3 commented 4 months ago

@TeaJayyy thanks for the quick reply! so, i would say we should skip it for now and prioritize release.

TeaJayyy commented 4 months ago

@hom3mad3 Yes sure, thought it would be an easy fix :(

hom3mad3 commented 4 months ago

@TeaJayyy unfortunately, whenever we need some dynamic change to the page it's usually not such an easy fix on a django platform.

goapunk commented 4 months ago

@hom3mad3 @TeaJayyy This worked before I updated the documents for the new ckeditor and should be easy to fix (it just reloads the page if the save was successful). I can look into why it stopped working

TeaJayyy commented 4 months ago

@goapunk I love easy fixes!