search

liqd / adhocracy-plus

adhocracy+ is a SaaS platform to make digital democracy easy for everyone
https://adhocracy.plus/
GNU Affero General Public License v3.0
77 stars 20 forks source link

denied access to semi-private project starting in future #901

Closed CarolingerSeilchenspringer closed 3 years ago

CarolingerSeilchenspringer commented 3 years ago

URL: https://aplus-dev.liqd.net/liqd-tests/ user: both invited & registered user and ununivited & unregistered users expected behaviour: clicking on the project tile opens the project behaviour: I get a 403 (invited user) or the log-in-form (uninvited user) important screensize: device & browser: Comment/Question: this is only when project start is in the future!!

Screenshot?

Rineee commented 3 years ago

Here is another example of it: https://aplus-dev.liqd.net/rines-test-orga/

Rineee commented 3 years ago

So I found out that this has nothing to do with semi-public projects, but is a bug that must have been there all the time, haha.. It is the same for public projects and is caused by this line.

I dont know why this rule was defined like this in the first place, so wasnt sure how to fix it :grimacing: But I guess @fuzzylogic2000 or @rmader will :)

fuzzylogic2000 commented 3 years ago

@Rineee Oh, yes, I can remember that I have seen that! It was to make sure, that documents and polls can only be viewed when they are not being changed anymore. I think, I already removed it from the topic prios. As the modules can now be added to or removed from the project, I think, this rule doesn't make sense anymore. Just the polls do look a bit weird, when they are shown before the phase starts. I think, it is still an improvement from a 403?

fuzzylogic2000 commented 3 years ago

@carolinger This issue was quite an old one and had nothing to do with the semi-private projects. It's there for every document and poll. (And should also be an issue in mB.) Even though, it looks a bit weird for the polls, I think we should remove this rule and make them viewable also prior to the phase? I will open an PR fixing this.

CarolingerSeilchenspringer commented 3 years ago

@fuzzylogic2000 it has already been changed on meinBerlin so I would also agree to it (nobody has ever complained there).