liqd / adhocracy

Adhocracy is a policy drafting and decision making software for distributed groups and open institutions.
GNU Affero General Public License v3.0
150 stars 37 forks source link

fix page/proposal title validation #852

Closed xi closed 10 years ago

xi commented 10 years ago

Unfortunately, #849 did not really solve the issue but revealed many more problems. As a result I refactored the whole page/proposal form validation.

I am sorry for the large commit. I did not know how to split this up. Some notes that might be helpful:

nidico commented 10 years ago

We've discussed that in length and came to the conclusion that this PR makes things better, even if the behavior is still a bit bizarre (you can create duplicate titles only by renaming) and we still don't fully understand whether labels have a meaning in proposals. However there is at least a clear concept (labels are unique and never change whereas titles can be changed).

We also discussed whether we need a migration due to this: Due to the previous behavior, there can be delegateables with duplicate labels, which we now assume to not exist. This shouldn't matter much though (or not less than before).