search

liqd / adhocracy

Adhocracy is a policy drafting and decision making software for distributed groups and open institutions.
GNU Affero General Public License v3.0
150 stars 37 forks source link

allow to link to inline rows #904

Closed xi closed 10 years ago

xi commented 10 years ago

This allows to link to proposal pager rows. On inline rows (see #733) it also expands the row. The link is available from the expand button.

The javascript expands the row on page load. If I just change the fragment, no reload is triggered and so the javascript is not executed. This could be fixed using the hashchange event.

JQuery's :target selector did not work for some reason so I fell back to window.location which is currently not supported in IE. I guess this is acceptable in this case.

xi commented 10 years ago

On second look, the window.location does seem to be supported in all major browsers after all.

nidico commented 10 years ago

We just discovered that the individual links aren't permanent due to pagination. If an item is linked to from a category page and the item's category changes, the link also breaks.

We decided to merge it anyway, as it is still useful in some cases and doesn't break the others.