search

liqd / aula

An online platform for political participation in schools in Germany (not in active development)
https://liqd.net
Other
27 stars 5 forks source link

Flip delegation tab names on the user profile page. #993

Closed andorp closed 8 years ago

andorp commented 8 years ago

Fixes: #991

fisx commented 8 years ago

LGTM! can be merged when travis is green.

fisx commented 8 years ago

(i wouldn't have added the explanation in two different places for fear of diverging changes, but on second thoughts, the fact that it's easier to find may outweigh this hypothetical problem.)

fisx commented 8 years ago

thanks!

andorp commented 8 years ago

(i wouldn't have added the explanation in two different places for fear of diverging changes, but on second thoughts, the fact that it's easier to find may outweigh this hypothetical problem.)

I thought those are the two occurences, even it would be better to use the Delegate and Delegatee newtype everywhere where it applies, but that would be a bigger change.