Open philli-m opened 2 years ago
@maxliqd Do you know if we use these blocks and if yes where and what for? We could remove the non-used ones if they are suuuperold and not used or fix them (like the paragraph one we should probably fix).
@phillimorland What do you mean with the padding? Did you already fix it? (I cannot see what's wrong.)
Edited: you do mean it is wrong in the blocks, but fine on the academy page, right? :) I might fix the blocks thing, then!
@phillimorland What do you mean with the padding? Did you already fix it? (I cannot see what's wrong.)
Edited: you do mean it is wrong in the blocks, but fine on the academy page, right? :) I might fix the blocks thing, then!
No, I added that, but it looks fine now, so seems fixed!
I checked a couple of pages, could not finde those blocks anywhere, if that helps @fuzzylogic2000
Home page
About
Join us
Demokratie für alle (project)
@maxliqd sorry, I'm not sure above means? is that the blocks that are not used or the blocks that are used? and what would you like us to do with them? also just a heads up, adding urls instead of pages names means we can find things much quicker, just for future :)
@phillimorland It is the ones we use on the pages
I couldn't find any of the broken blocks, apart from the paragraph block, but I also did not check all pages. Let me know if I should check a bit deeper.
@maxliqd thanks for clarification! If it is ok with you we will delete the image slider block as will be a lot of work to make it functional again. The other unused blocks we can either neaten up in case you wish to use them in future or we can delete so them are not accidentally added and look bad. Which would you prefer?
@phillimorland I think I cannot answer this on my own, would need to ask someone from PR, probably Moritz, as I don't really know the initial purpose of the blocks. I will remove the issue from the milestone for now.
@maxliqd @phillimorland Thank you for looking into this! As far as I am aware we only need the paragraph block. The image slider, grey paragraph and quote block all came from the previous liqd.net design before 2017 and were probably carried over. They should not be in use anymore on the current design.
https://dev.liqd.net/en/blocks/ on landing page: