[Issue #455] Add support for IPv6 addresses in allow_ips configuration

liqd / thentos

A tool for privacy-preserving identity management (PPIM)

Other

56 stars 9 forks source link

[Issue #455] Add support for IPv6 addresses in allow_ips configuration #469

Closed np closed 8 years ago

np commented 8 years ago

Instead of inet_addr, use getAddrInfo which supports IPv6
A new module Network.HostAddr including:
- HostAddr a type wrapping the different kind of addresses
- getHostAddr a wrapper over getAddrInfo returning a HostAddr
- hostAddr extract HostAddr from a SockAddr

fisx commented 8 years ago

Thanks @np, could you comment / act on my last remark and pass back to me? If you don't want to change your error handling I guess we can argue that the init* function I mentioned earlier should rule out both errors at start time.

fisx commented 8 years ago

(I just found #464 with the old comments. Sorry for the noise!)

np commented 8 years ago

I would wait for this init* function, in particular if we can't trigger these "impossible" cases.

fisx commented 8 years ago

Makes sense now. Sorry for being so slow. :-)