search

liqd / thentos

A tool for privacy-preserving identity management (PPIM)
Other
56 stars 9 forks source link

Refactoring in Thentos.Transaction and Thentos.Backend.Api.SimpleSpec #479

Closed np closed 8 years ago

np commented 8 years ago
fisx commented 8 years ago

Nice. I like PRs that remove more lines than they add.

fisx commented 8 years ago

Can you fix the typo (if it is one) and merge yourself?

fisx commented 8 years ago

Travis needs to be run again (selenium is a bit shaky), and the NOPE is still there, I think. Otherwise ready to merge.

np commented 8 years ago

My analysis was wrong as I didn't yet look at catcher in Thentos.Transaction.Core

fisx commented 8 years ago

Erm, but that's not what happens here, no? You get back a list of 0, 1, or many entries from sql, not an error.

fisx commented 8 years ago

Ok, got it, you are right. The comment was correct. Can you revert this?

fisx commented 8 years ago

I'm bad at reading diffs, sorry. You didn't remove the line, just the NOPE.

Ignore this noise. (-: