search

liquality / chainify

Blockchain abstraction layer
https://liquality.io
MIT License
220 stars 69 forks source link

Near tests: Catch reject instead of exceptions #418

Closed DesWurstes closed 3 years ago

DesWurstes commented 3 years ago

415 caused below to be printed every time a Near validation test passes:

  Near Swap provider
    Generate swap
      Swap contract address validation
        ✓ should throw error with address wrong type
(node:50674) UnhandledPromiseRejectionWarning: InvalidAddressError: Invalid address: undefined
    at validateAddress (webpack://@liquality/near-utils/./lib/index.ts?:43:15)
    at Object.validateSwapParams (webpack://@liquality/near-utils/./lib/index.ts?:34:5)
    at NearSwapProvider.<anonymous> (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/lib/NearSwapProvider.ts:30:5)
    at step (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/lib/NearSwapProvider.ts:48:23)
    at Object.next (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/lib/NearSwapProvider.ts:29:53)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/lib/NearSwapProvider.ts:23:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/lib/NearSwapProvider.ts:19:12)
    at NearSwapProvider.initiateSwap (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/lib/NearSwapProvider.ts:77:16)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:21:20
    at Proxy.assertThrows (/Users/goo/Downloads/chainabstractionlayer2/node_modules/chai/lib/chai/core/assertions.js:2648:7)
    at Proxy.methodWrapper (/Users/goo/Downloads/chainabstractionlayer2/node_modules/chai/lib/chai/utils/addMethod.js:57:25)
    at doAsserterAsyncAndAddThen (/Users/goo/Downloads/chainabstractionlayer2/node_modules/chai-as-promised/lib/chai-as-promised.js:289:22)
    at Proxy.<anonymous> (/Users/goo/Downloads/chainabstractionlayer2/node_modules/chai-as-promised/lib/chai-as-promised.js:255:20)
    at Proxy.overwritingMethodWrapper (/Users/goo/Downloads/chainabstractionlayer2/node_modules/chai/lib/chai/utils/overwriteMethod.js:78:33)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:29:20
    at step (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:33:23)
    at Object.next (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:14:53)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:8:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:4:12)
    at testRecipientAddress (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:57:28)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:49:9
    at step (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:33:23)
    at Object.next (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:14:53)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:8:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:4:12)
    at Context.<anonymous> (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:47:56)
    at callFn (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runnable.js:387:21)
    at Test.Runnable.run (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runnable.js:379:7)
    at Runner.runTest (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:535:10)
    at /Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:653:12
    at next (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:447:14)
    at /Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:457:7
    at next (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:362:14)
    at Immediate.<anonymous> (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:425:5)
    at processImmediate (internal/timers.js:461:21)
(node:50674) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 5)
(node:50674) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:50674) UnhandledPromiseRejectionWarning: AssertionError: expected [Function] to throw an error
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:29:20
    at step (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:33:23)
    at Object.next (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:14:53)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:8:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:4:12)
    at testRecipientAddress (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:57:28)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:49:9
    at step (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:33:23)
    at Object.next (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:14:53)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:8:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:4:12)
    at Context.<anonymous> (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:47:56)
    at callFn (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runnable.js:387:21)
    at Test.Runnable.run (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runnable.js:379:7)
    at Runner.runTest (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:535:10)
    at /Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:653:12
    at next (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:447:14)
    at /Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:457:7
    at next (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:362:14)
    at Immediate.<anonymous> (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:425:5)
    at processImmediate (internal/timers.js:461:21)
(node:50674) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 6)
(node:50674) UnhandledPromiseRejectionWarning: InvalidAddressError: Invalid address: undefined
    at validateAddress (webpack://@liquality/near-utils/./lib/index.ts?:43:15)
    at Object.validateSwapParams (webpack://@liquality/near-utils/./lib/index.ts?:35:5)
    at NearSwapProvider.<anonymous> (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/lib/NearSwapProvider.ts:30:5)
    at step (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/lib/NearSwapProvider.ts:48:23)
    at Object.next (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/lib/NearSwapProvider.ts:29:53)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/lib/NearSwapProvider.ts:23:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/lib/NearSwapProvider.ts:19:12)
    at NearSwapProvider.initiateSwap (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/lib/NearSwapProvider.ts:77:16)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:35:20
    at Proxy.assertThrows (/Users/goo/Downloads/chainabstractionlayer2/node_modules/chai/lib/chai/core/assertions.js:2648:7)
    at Proxy.methodWrapper (/Users/goo/Downloads/chainabstractionlayer2/node_modules/chai/lib/chai/utils/addMethod.js:57:25)
    at doAsserterAsyncAndAddThen (/Users/goo/Downloads/chainabstractionlayer2/node_modules/chai-as-promised/lib/chai-as-promised.js:289:22)
    at Proxy.<anonymous> (/Users/goo/Downloads/chainabstractionlayer2/node_modules/chai-as-promised/lib/chai-as-promised.js:255:20)
    at Proxy.overwritingMethodWrapper (/Users/goo/Downloads/chainabstractionlayer2/node_modules/chai/lib/chai/utils/overwriteMethod.js:78:33)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:43:20
    at step (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:33:23)
    at Object.next (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:14:53)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:8:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:4:12)
    at testRefundAddress (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:74:28)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:51:9
    at step (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:33:23)
    at Object.next (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:14:53)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:8:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:4:12)
    at Context.<anonymous> (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:47:56)
    at callFn (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runnable.js:387:21)
    at Test.Runnable.run (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runnable.js:379:7)
    at Runner.runTest (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:535:10)
    at /Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:653:12
    at next (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:447:14)
    at /Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:457:7
    at next (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:362:14)
    at Immediate.<anonymous> (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:425:5)
    at processImmediate (internal/timers.js:461:21)
(node:50674) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 7)
(node:50674) UnhandledPromiseRejectionWarning: AssertionError: expected [Function] to throw an error
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:43:20
    at step (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:33:23)
    at Object.next (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:14:53)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:8:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:4:12)
    at testRefundAddress (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:74:28)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:51:9
    at step (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:33:23)
    at Object.next (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:14:53)
    at /Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:8:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:4:12)
    at Context.<anonymous> (/Users/goo/Downloads/chainabstractionlayer2/packages/near-swap-provider/test/unit/index.test.ts:47:56)
    at callFn (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runnable.js:387:21)
    at Test.Runnable.run (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runnable.js:379:7)
    at Runner.runTest (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:535:10)
    at /Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:653:12
    at next (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:447:14)
    at /Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:457:7
    at next (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:362:14)
    at Immediate.<anonymous> (/Users/goo/Downloads/chainabstractionlayer2/node_modules/mocha/lib/runner.js:425:5)
    at processImmediate (internal/timers.js:461:21)
(node:50674) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 8)

We need to listen for rejections, not exceptions. in the context of promises