search

liquality / chainify

Blockchain abstraction layer
https://liquality.io
MIT License
220 stars 69 forks source link

Bitcoin Utils: Validate Address should succeed for proper p2sh-segwit addresses #429

Open matthewjablack opened 3 years ago

matthewjablack commented 3 years ago

Currently validateAddress fails for p2sh-segwit addresses in bitcoin-utils.

One would expect these types of addresses to succeed for all types of addresses... legacy, p2sh-segwit, segwit.

If this function is specifically to be used for validating swap addresses, then it should probably be renamed to validateSwapAddress.

kraikov commented 2 years ago

@monokh any actions here?