liquibase / liquibase-docs

8 stars 18 forks source link

Invalid schemaLocation in the "changelogs in XML Format" example #128

Closed hjoeren closed 2 years ago

hjoeren commented 2 years ago

Describe the bug In the "changelogs in XML Format" example snippet, the schemaLocation is invalid.

To Reproduce Steps to reproduce the behavior:

  1. https://docs.liquibase.com/concepts/basic/xml-format.html
  2. see the xsi:schemaLocation attribute of the databaseChangeLog root element

Expected behavior This would be the correct xsi:schemaLocation:

<databaseChangeLog  
        xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext" 
        xmlns:pro="http://www.liquibase.org/xml/ns/pro" 
        xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd
        http://www.liquibase.org/xml/ns/dbchangelog-ext http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd http://www.liquibase.org/xml/ns/pro http://www.liquibase.org/xml/ns/pro/liquibase-pro-4.3.xsd">
<!-- ... -->
</databaseChangeLog>

Actual behavior

(a http://www.liquibase.org/xml/ns/dbchangelog too much immediately before http://www.liquibase.org/xml/ns/pro/liquibase-pro-4.3.xsd)

<databaseChangeLog  
        xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext" 
        xmlns:pro="http://www.liquibase.org/xml/ns/pro" 
        xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd
        http://www.liquibase.org/xml/ns/dbchangelog-ext http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd http://www.liquibase.org/xml/ns/pro http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/pro/liquibase-pro-4.3.xsd">

Liquibase Version:

Additional context

nmelny commented 2 years ago

@hjoeren Thank you very much for reporting this! The issue is fixed. Please let me know if there is something else we can improve.