liquibase / liquibase-docs

7 stars 16 forks source link

validate goal added to maven-liquibase-plugin #133

Closed sync-by-unito[bot] closed 2 years ago

sync-by-unito[bot] commented 2 years ago

https://github.com/liquibase/liquibase/pull/2434

Need to be coordinated with next liquibase release. Thanks.

┆Issue is synchronized with this Jira Story by Unito ┆Attachments: Liquibase Maven Goal_ validate_v_0.1.docx

sync-by-unito[bot] commented 2 years ago

➤ Nataliya Melnyk commented:

Nathan Voxland Erzsebet Carmean May I ask you to review my documentation for Liquibase Maven Goal_ validatev0.1.docx? Since this is a new Maven goal (release-related), I would like us to include it in the upcoming release.

Also, could you please provide me with the output for this goal?

sync-by-unito[bot] commented 2 years ago

➤ Nathan Voxland commented:

Those settings all look good, except that you could take off promptOnNonLocalDatabase. It’s a deprecated setting which now does nothing no matter what you set it to.

The promptOnNonLocalDatabase should be similarly removed (or at least updated to say it’s deprecated and does nothing) across all the maven goal pages

Example output:

[ERROR] Validation Failed: [ERROR] 1 changes have validation failures [ERROR] column 'type' is required for all columns, com/example/changelog.xml::22::sampleor

[INFO] No validation errors found.

sync-by-unito[bot] commented 2 years ago

➤ Nataliya Melnyk commented:

Nathan Voxland Thank you a lot for your review. I removed promptOnNonLocalDatabase, and will remove it from every other Maven doc, but in scope of another ticket.

The documentation is published to staging env.