search

liquibase / liquibase-docs

7 stars 15 forks source link

added note in drop unique constraint to specify behavior for dropping index along with constraint in oracleDB #206

Closed Gh05ts closed 1 week ago

Gh05ts commented 6 months ago

We recently were caught off guard by this behavior as we explicitly added drop index after the drop constraint in our changeset and the deployment was failing with index does not exist error, so adding to avoid confusion.

https://github.com/liquibase/liquibase/blob/e605cee3c7795688b2d178a67c5fed818ac52d0e/liquibase-standard/src/main/java/liquibase/sqlgenerator/core/DropUniqueConstraintGenerator.java#L18

Had to read the code at line 40 to confirm and we ended up delivering a non-deploying build to QA internally.

If you would prefer to have the note mentioned in some other format or anything along those lines, please let me know or update according to documentation standards.

adrian-velonis1 commented 1 week ago

@Gh05ts Thanks for your PR. I've reviewed this and merged it with a small formatting change. We appreciate that you've taken the time to provide this clarification!

Apologies for the extremely slow response time. We've been working through a backlog of internal tickets.

If you have any other suggestions for the documentation, please feel free to submit additional PRs (you can tag me as reviewer) or use the "Feedback" button on the docs webpage itself.