liquibase / liquibase-gradle-plugin

A Gradle plugin for Liquibase
Other
200 stars 59 forks source link

Adding files to the plugin classpath #10

Closed sergeykad closed 5 years ago

sergeykad commented 8 years ago

It will be more convenient if it will be possible to modify classpath directly from the plugin configuration instead of Gradle buildscript configuration.

The Liquibase plugin requires at least DB connector jar to be added to the classpath and often other jars/files as well and putting them into the general configuration makes configuration less tidy.

atomfrede commented 6 years ago

I jump on this old issue here. I would like to replace our custom diffChangelog task in https://github.com/jhipster/generator-jhipster with this plugin to support all other liquibase tasks out of box without custom code.

So I need to add spring dependencies to the classpath of the plugin. It is not very convinient to add them to the buildscript classpath, so if there would a possibility to add dependencies to the plugin classpath that would be awesome.

Furthermore putting the diffChangelog into a file would be cool :)

stevesaliman commented 6 years ago

Version 2.0.0 of the Liquibase Gradle plugin changed the way the classpath is set for Liquibase, which might fix this issue. You can now easily add any artifacts you need with liquibaseRuntime dependencies inside the normal dependencies block of the build.gradle file.

Does this problem still occur in the 2.0.0 relesae?

atomfrede commented 6 years ago

Thanks for the hint. Will try it during the weekend

atomfrede commented 6 years ago

@stevesaliman It is done: https://github.com/jhipster/generator-jhipster/pull/8171/files so be prepated for more issues coming in maybe after we have released the change. I will open another issue with some things I found during implementing it.

atomfrede commented 6 years ago

@stevesaliman I think we can close this issue.