search

liquibase / node-liquibase

Node.js wrap for Liquibase
MIT License
32 stars 14 forks source link

DAT-17582 Liquibase NPM default connection- edit summary Liquibase NPM default connection #102

Closed jandroav closed 2 weeks ago

jandroav commented 2 weeks ago

When we run npm run build for the script below, liquibase uses POSTGRESQL_DEFAULT_CONFIG from liquibase.cjs.development.jsfile instead of the providedmyConfig. Looks like it’s hardcoded 

const Liquibase = require('liquibase').Liquibase;

const myConfig = {
  defaultsFile: '/home/rberezenskyi/Downloads/liquibase-4.27.0/liquibase1.properties'
}
const instTs = new Liquibase(myConfig);

instTs.status();

I think the issue is here: node-liquibase/src/liquibase.ts at 40e9500af64e47879dd73b5f50f70c95cfb86714 · liquibase/node-liquibase

We could remove ...POSTGRESQL_DEFAULT_CONFIG, although we would need to update the docs to ensure that Users know there is no default config anymore. Also, at that point, we should probably remove the entire method.