search

liquibase / node-liquibase

Node.js wrap for Liquibase
MIT License
32 stars 14 forks source link

Node liquibase v4.4.0 fails when suppied Liquibase Pro License Key #37

Open RajarsiGit opened 3 years ago

RajarsiGit commented 3 years ago

Context: Node liquibase (latest) fails to execute when parameters like Pro License Keys are supplied

Node-Liquibase Version: 4.4.0

Liquibase Version (if not bundled)

Description

When parameters such as Liquibase Pro License Key, Liquibase Hub Project Id, and other keys or ids are supplied as parameters or as part of Liquibase properties file, the latest version of node Liquibase v4.4.0 fails (earlier versions work perfectly).

Steps to Reproduce

  1. Install the latest node Liquibase package (v4.4.0)
  2. Add database details and Liquibase Pro License key as parameters or inside Liquibase properties file.
  3. Add any command function such as status, update, and so on..
  4. Save and run JS/TS file

Expected behavior: Should perform its function such as update or display status

Actual behavior: Displays error such as the one below:

image

mariochampion commented 3 years ago

hey @nvoxland -- can you take a look at this as well, since it worked pre-refactor. thanks!

nvoxland commented 3 years ago

We have a ticket for it for possibly including in 4.4.1. It's in our internal tracker, so can't have a handy link.

DAT-7419

tabuckner commented 2 years ago

DAT-7419 is now done. Looks like it was included in 4.4.1

@RajarsiGit It looks like you were previously using the "bundled" offering of node-liquibase. Our @pd or "Peer Dependency" version of node-liquibase allows you to use whatever version of liquibase you'd like.

You should be able to use the @pd version of node-liquibase with version 4.4.1 of liquibase and resolve the issue you reported here.

Does that work for you?

RajarsiGit commented 2 years ago

Yes works for me. Thanks @tabuckner