szandany commented 4 years ago

added placeholders for 'run(action = '', params = '')' in line 67" in the index.js file.

codecov[bot] commented 4 years ago

Codecov Report

Merging #5 into staging will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##           staging        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           34        34           
=========================================
  Hits            34        34

Impacted Files	Coverage Δ
src/index.js	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d57a66c...dd0c15f. Read the comment docs.

alan-czajkowski commented 3 years ago

is this project in active development? would be nice to have :)

tabuckner commented 3 years ago

@alan-czajkowski definitely! what's your use case?

alan-czajkowski commented 3 years ago

@tabuckner currently using Liquibase with Java Spring Boot apps, and would like to continue using the framework for NodeJS apps (talking to Oracle)

jgtvares commented 3 years ago

Quick question: why is this lib using Liquibase 4.0 beta1 version? Is there any intention to upgrade? I'm experiencing this issue. And it seems to have been fixed already in newer versions!

tabuckner commented 3 years ago

@alan-czajkowski @jgtvares Hey guys, recently re-released this library after some refactoring and wanted to let you guys know I took your comments into consideration:

@alan-czajkowski The new release has a substantially different API than the previous release which relied heavily on an understanding of how Liquibase works. I would love if you could take a look at the new setup here. Now it has support for TypeScript, a proxied API that brings Liquibase core into the Node world in a familiar fashion.
@jgtvares I've also just released a zero-dependency version of the library under the npm tag @pd for Peer Dependency. This will allow you to use any version of Liquibase you like with a couple minor changes to the configuration of node-liquibase. If you're still interested in using what I've dubbed a 'Bundled Version' of this library, you can find NPM releases here and some information about how to select the correct version of node-liquibase here. I'll provide a short description below of how it works.

Deciding Which Version of node-liquibase to Use The major and minor version numbers of node-liquibase will align with a corresponding Liquibase Core release.

For Example:

"I want to use Liquibase v4.3.3 in a Node application."

yarn add liquibase@4.3

This should (I think, anyways 😂 ) install the latest patch version of node-liquibase 4.3.x, which will contain a 'bundled' Liquibase Core at v4.3.3. It is safe to assume that the patch number of node-liquibase will not reliably align with Liquibase Core.

tabuckner commented 3 years ago

Closing this PR as previous library has been deprecated.

alan-czajkowski commented 3 years ago

@tabuckner thank you for your efforts!

jgtvares commented 3 years ago

@tabuckner Thank you for taking our issues into account! :pray:

liquibase / node-liquibase

added placeholders for run(action = <action>, params = <action-params>) in line 67 #5

Codecov Report