DAT-4596 NPM distribution

liquibase / node-liquibase

Node.js wrap for Liquibase

MIT License

32 stars 15 forks source link

DAT-4596 NPM distribution #95

Closed jandroav closed 5 months ago

jandroav commented 7 months ago

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[ x Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

[x] Does your submission pass tests?
[x] Have you lint your code locally prior to submission?

Changes to Core Features:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

jandroav commented 7 months ago

I could not add @tabuckner to this PR

jnewton03 commented 7 months ago

would be good to get @mcred to review the protobuf piece of this as well.

jandroav commented 7 months ago

Yup, just to clarify: for now the protobuf stuff is only generating proto files, and then the ts-proto node package is converting them to TypeScript code under the proto-commands folder. Divergences in proto-commands will pop up in a PR if some new liquibase command is added (or a modification for an existing one)

The second phase is what you pointed @jnewton03 about the Golang parser.

jandroav commented 5 months ago

I am merging this to be able to run the /liquibase/node-liquibase/.github/workflows/generate.yml for liquibase 4.27.0