Review all code changes. Verify the submitter attestations belowe, checking off each statement to indicate that you have reviewed the statement and it is true to the best of your knowledge. If you do not agree with or are unsure of a statement, then add a comment describing your questions or concerns and contact the submitter @zanerock for clarification.
Do the changes implement all concrete TODOs in the change ticket? y (_CHANGES_IMPLEMENT_ALLTODOS=true)
Are there other changes not described in the original work description? n (_CHANGES_HAS_ADDITIONALCHANGES=false)
Are there any QA exceptions which need to be addressed? n (_CHANGES_HAS_QAEXCEPTIONS=false)
Do the changes add or involve connections, authentication, or queries to a database or any third-party service? n (_CHANGES_THIRD_PARTY_SERVICESMODIFIED=false)
Has all debug, hard coded test data, and hard coded authentication data been removed? y (_CHANGES_DEBUGREMOVED=true)
[x] I have reviewed and verified the above are true to the best of my knowledge.
Pull request to resolve #5
Submitted by: zanerock
Instructions
Review all code changes. Verify the submitter attestations belowe, checking off each statement to indicate that you have reviewed the statement and it is true to the best of your knowledge. If you do not agree with or are unsure of a statement, then add a comment describing your questions or concerns and contact the submitter @zanerock for clarification.
QA files
Submitter attestations
To be verified by reviewer.