search

liquidaty / zsv

zsv+lib: tabular data swiss-army knife CLI + world's fastest (simd) CSV parser
MIT License
202 stars 12 forks source link

Fix warnings while extracting JQ archive #204

Open iamazeem opened 6 hours ago

iamazeem commented 6 hours ago

On Linux, there are these unknown extended headers warnings while extracting jq-1.6.tar.bz2:

$ cd /home/runner/work/zsv/zsv/build/Linux/rel/musl-gcc/external/jq-src-tmp && tar xf /home/runner/work/zsv/zsv/app/external/jq-1.6.tar.bz2
tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.quarantine'
tar: Ignoring unknown extended header keyword 'LIBARCHIVE.xattr.com.apple.provenance'
...

According to this SO thread, the archive needs to recompressed. Need to test and verity this.

iamazeem commented 5 hours ago

@liquidaty: Compared https://github.com/liquidaty/zsv/blob/main/app/external/jq-1.6.tar.bz2 with the official release (https://github.com/jqlang/jq/releases/download/jq-1.6/jq-1.6.tar.gz) and both are identical. :thinking: Seems like ours has been extracted and re-archived on macOS. Shouldn't we use and store the official one?

Also, there's been new release https://github.com/jqlang/jq/releases/tag/jq-1.7.1 with security fixes. Shouldn't we use this one?