search

liquidcarrot / carrot

🥕 Evolutionary Neural Networks in JavaScript
https://liquidcarrot.io/carrot/
MIT License
293 stars 34 forks source link

Fix incorrect array slicing parameters #258

Open raimannma opened 3 years ago

raimannma commented 3 years ago

REBASED VERSION from steven nguyen

Ugh I keep getting this error. I put in so many layers!!!! image

I looked at the code to try to do it myself but I ended up finding a bug instead.

Code changed: Array.slice(0, -1) instead of Array.slice(Start at length - 1) https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/slice

raimannma commented 3 years ago

@christianechevarria Is it possible to add a bit tolerance to coveralls check?

icecream17 commented 3 years ago

I just realized it might be better to do Array.pop() instead of Array.slice(0, -1)