search

liquidctl / liquidtux

Linux kernel hwmon drivers for AIO liquid coolers and other devices
Other
80 stars 15 forks source link

nzxt-kraken3: Mark get_fw_version_cmd as __maybe_unused #48

Closed aleksamagicka closed 1 year ago

aleksamagicka commented 1 year ago

Fixes #46.

amezin commented 1 year ago

__maybe_unused seems to be the preferred way https://www.spinics.net/lists/linux-hwmon/msg13905.html

amezin commented 1 year ago

And now the commit message doesn't match the actual diff :)

Besides that, I now noticed that constants aren't const for some reason (this is for a separate change/pull request of course)

aleksamagicka commented 1 year ago

I know, I pushed just to see if it passes CI. Dkms is failing in my repo for some reason.

On Wed, Feb 22, 2023, 8:43 AM Aleksandr Mezin @.***> wrote:

And now the commit message doesn't match the actual diff :)

Besides that, I now noticed that constants aren't const for some reason (this is for a separate change/pull request of course)

— Reply to this email directly, view it on GitHub https://github.com/liquidctl/liquidtux/pull/48#issuecomment-1439563404, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQGRILNCVCZIR7QLTZTDQ3WYW7TLANCNFSM6AAAAAAVD6RJRU . You are receiving this because you authored the thread.Message ID: @.***>

amezin commented 1 year ago

I know, I pushed just to see if it passes CI. Dkms is failing in my repo for some reason.

fatal: No names found, cannot describe anything.

There are no tags, so gitversion.sh fails.