search

liquidctl / liquidtux

Linux kernel hwmon drivers for AIO liquid coolers and other devices
Other
79 stars 14 forks source link

github: set CONFIG_HID_SUPPORT=y for Kconfig in mainline #51

Closed jonasmalacofilho closed 1 year ago

jonasmalacofilho commented 1 year ago

Fixes recently failed actions: e.g. https://github.com/liquidctl/liquidtux/actions/runs/4248327829/jobs/7387378110. Related: torvalds/linux@25621bcc8976

This feels like a workaround though. Shouldn't USB_HID select HID_SUPPORT instead of HID?

Personally, I don't find the descriptions in the linked commit that clear, but I guess it will be solved in upstream momentarily (if necessary).

aleksamagicka commented 1 year ago

HID_SUPPORT which is introduced there (github link) is just a giant on-off switch for everything related to HID. HID-BPF is an extension of HID, so I guess if you don't want to have HID at all, then you also don't want its BPF extension.

USB_HID selects HID because that's the core code, it doesn't need all the drivers beneath. That's my understanding at least. And if CONFIG_HID_SUPPORT is not y, you don't get anything related to HID, as intended.

jonasmalacofilho commented 1 year ago

That makes sense. And thanks for the review.