search

liquidctl / liquidtux

Linux kernel hwmon drivers for AIO liquid coolers and other devices
Other
79 stars 14 forks source link

Building with W=1? #60

Open aleksamagicka opened 8 months ago

aleksamagicka commented 8 months ago

Just found a very interesting discussion starting here, related to the warnings that the 0-day bot finds and how to find them before sending the patch upstream.

Guenter then summed up his requirements. We already have checkpatch CI here, so adding W=1 seems like a good thing to add as well.

Thoughts? Maybe also add C=1 (that invokes sparse)?

jonasmalacofilho commented 8 months ago

[... rant omitted ...]

In that case, we should add both W=1 and C=1... and the other checkers too, if possible.

You must build your new driver with W=1, smatch, sparse and coccinelle before sending upstream.