search

liquidctl / liquidtux

Linux kernel hwmon drivers for AIO liquid coolers and other devices
Other
79 stars 14 forks source link

fix init interval for kraken3 #9

Closed stalkerg closed 3 years ago

stalkerg commented 3 years ago

Before we did a dangerous memcpy and sent only 2 bytes. I suppose for only 2 commands much better to use the explicit way.

stalkerg commented 3 years ago

yes, now it's working as expected

stalkerg commented 3 years ago

It's bounded with the #7 issue.

jonasmalacofilho commented 3 years ago

I don't think that the memcpy was dangerous, but I also like the explicit alternative. And thanks for the fix.

Please leave your suitable Signed-off-by/Co-developed-by tags here; they will be necessary when we decide to upstream this driver.

stalkerg commented 3 years ago

As I understand right:

Co-developed-by: Yury Zhuravlev <stalkerg@gmail.com>
Signed-off-by: Yury Zhuravlev <stalkerg@gmail.com>