Unbashify script inside nomad template

[RazorBest]

A script inside a nomad template was using exclusive bash syntax, but it was run with /bin/sh. There were 2 solutions: run it with bash or change the script in accordance to POSIX. I chose the second method.

[gabriel-v]

Sure, but the tests are failing.

I suggest we use bash everywhere instead of editing scripts to remove double [[:

• change shebang line from sh to bash: https://github.com/liquidinvestigations/node/blob/cd9903d56bb3d295a9f16d0a7e3b3da80d0d8f57/templates/hoover.nomad#L49
• change program line from sh to bash: https://github.com/liquidinvestigations/node/blob/cd9903d56bb3d295a9f16d0a7e3b3da80d0d8f57/templates/hoover.nomad#L327
  • a search for "sh" and /bin/sh yields a lot of results; could you please remove sh from everywhere where possible?

Note: I expect some containers (those based off Alpine) won't have bash already installed. In those cases, it's best to remove the bash features like you did, and maybe document them through a comment (something like # this image doesn't have bash!!1!)

[gabriel-v]

merged to master