search

liquidm / ruby-druid

Ruby utilities for metamx druid
MIT License
43 stars 34 forks source link

Allow custom javascript filter functions #32

Closed mikwat closed 9 years ago

mikwat commented 9 years ago

We have the need to specify custom javascript filter functions that cannot be wrapped within a return(...) statement. This change just moves the return into the new_comparison method to make FilterJavascript more flexible. Existing specs pass.

hollow commented 9 years ago

Hi @mikwat. Thanks for your PR. We are currently moving the repository to ruby-druid/ruby-druid and all new work has been pushed there already. Could you please open your PR in the new repository?

Also, @sixtus, please commit a deprecation notice into the liquidm fork.

mikwat commented 9 years ago

Thanks @hollow Will do.