Little mistake in slick.js

liquidm / slickgrid-rails

SlickGrid integration for Rails 3.1+

MIT License

24 stars 23 forks source link

Little mistake in slick.js #1

Closed itkin closed 12 years ago

itkin commented 12 years ago

line 2 should be

//= require jquery/event/drag

instead of

//= require jquery/event.drag

... but still i have to copy the jquery-plugins-rails javascript forler in my vendor/assets to load theese gem's files from my manifest do you have the same behavior (i'm on rails rails-3.2.0 and sprockets-2.1.2)

hollow commented 12 years ago

this has already been fixed in f3ef3893. regarding the jquery-plugins-rails gem: i don't need to copy them anywhere. sprockets should pick them up by itself ...

diegodorado commented 11 years ago

there is still an omission: docs says nothing about requiring these files

diegodorado commented 11 years ago

shouldn't gem 'jquery-plugins-rails' be a dependency ?

AlJohri commented 11 years ago

This should indeed by a dependency as far as my testing.

stanchiang commented 11 years ago

i had the same issue: ended up copying jquery folder from "jquery-plugins-rails-0.1.1\vendor\assets\javascripts" into "slickgrid-rails-0.2.0\vendor\assets\javascripts" folder.