search

liquidmetal-dev / flintlock

Lock, Stock, and Two Smoking MicroVMs. Create and manage the lifecycle of MicroVMs backed by containerd.
https://flintlock.liquidmetal.dev/
Mozilla Public License 2.0
580 stars 36 forks source link

Backfill unit tests for `infrastructure/network/network_service.go` #244

Open Callisto13 opened 2 years ago

Callisto13 commented 2 years ago

yikes 😬

goku321 commented 2 years ago

I can try my hands on this one

Callisto13 commented 2 years ago

Awesome! It's all yours 👍 . We are in the process of writing up our "testing standards", so I can't share that with you yet, but check out the section in contributing and feel free to ping us if you need anything

Callisto13 commented 2 years ago

Also if you need to refactor the code to make it better and more testable feel free 👍

goku321 commented 2 years ago

Sure. Thanks, @Callisto13 🙂

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 60 days with no activity.

goku321 commented 2 years ago

Not stale. I got caught with other things. Planning to spend time on this coming weekend.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 60 days with no activity.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity.

github-actions[bot] commented 5 months ago

This issue was closed because it has been stalled for 365 days with no activity.