liquidnft / lnft

Liquid NFT Platform
GNU Affero General Public License v3.0
56 stars 23 forks source link

Meta for Artwork Page is not correct #25

Open ihorml opened 3 years ago

ihorml commented 3 years ago

During my work on a redesign, I noticed that in Head.svelte we have the following code:

<svelte:head>
  <meta name="twitter:card" content="summary_large_image" />
  <meta name="twitter:site" content="@raretoshi" />
  <meta name="twitter:creator" content="@raretoshi" />

  {#if $art}
    <meta property="og:title" content={`Raretoshi - ${$art.title}`} />
    <meta property="og:image" content={`/api/ipfs/${$art.filename}`} />
    <meta property="og:url" content={`https://raretoshi.com/a/${$art.slug}`} />
    <meta name="twitter:title" content={`Raretoshi - ${$art.title}`} />
    <meta name="twitter:image" content={`/api/ipfs/${$art.filename}`} />
  {:else}
    <meta property="og:title" content="Raretoshi" />
    <meta property="og:image" content="https://raretoshi.com/splash.png" />
    <meta property="og:url" content="https://raretoshi.com/" />
    <meta name="twitter:title" content="Raretoshi" />
    <meta name="twitter:image" content="https://raretoshi.com/splash.png" />
  {/if}
</svelte:head>

But during my tests, I figured out that we don't display different meta for Artwork. For e.g. - https://raretoshi.com/a/toxic-money-fiat-scavenger-2-14181

  <meta name="keywords" content="Bitcoin Liquid NFT Art" />
  <meta name="twitter:card" content="summary_large_image" data-svelte="svelte-14cogqk">
  <meta name="twitter:site" content="@raretoshi" data-svelte="svelte-14cogqk">
  <meta name="twitter:creator" content="@raretoshi" data-svelte="svelte-14cogqk">
  <meta property="og:title" content="Raretoshi" data-svelte="svelte-14cogqk">
  <meta property="og:image" content="https://raretoshi.com/splash.png" data-svelte="svelte-14cogqk">
  <meta property="og:url" content="https://raretoshi.com/" data-svelte="svelte-14cogqk">
  <meta name="twitter:title" content="Raretoshi" data-svelte="svelte-14cogqk">
  <meta name="twitter:image" content="https://raretoshi.com/splash.png" data-svelte="svelte-14cogqk">

The meta remains the same