Support for non-string projection keys added

liquidprojections / LiquidProjections

Liquid Projections supports building and maintaining autonomous .NET projection code in an Event Sourcing architecture.

https://www.liquidprojections.net

MIT License

169 stars 25 forks source link

Support for non-string projection keys added #47

Closed IharBury closed 8 years ago

IharBury commented 8 years ago

Fixes #43

dennisdoomen commented 8 years ago

Actually, I think it would be fine not to support anything but a string. Either we do that, or we need to support it for the RavenProjector as well (albeit would convert it to strings implicitly).

IharBury commented 8 years ago

We've discussed in person and decided to allow any key type in RavenDB events but always convert it to a string via Convert.ToString with CultureInfo.InvariantCulture. We may provide conversion customization support in a future version.

IharBury commented 8 years ago

I've applied the discussed changes to RavenDB but I don't really like the result. So I've created a separate pull request for it #48